Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android logging with MockWebServer on API 21-23 #6220

Closed
yschimke opened this issue Aug 13, 2020 · 5 comments
Closed

Fix android logging with MockWebServer on API 21-23 #6220

yschimke opened this issue Aug 13, 2020 · 5 comments
Labels
bug Bug in existing code
Milestone

Comments

@yschimke
Copy link
Collaborator

We already avoid logging in Android extending past 23 characters, we should fix for MockWebServer also. This was probably broken by me.

https://stackoverflow.com/questions/63387807/java-lang-illegalargumentexception-log-tag-okhttp3-mockwebserver-mockwebserver

this[OkHttpClient::class.java.name] = "okhttp.OkHttpClient"

@yschimke yschimke added the bug Bug in existing code label Aug 13, 2020
@russell-shizhen
Copy link
Contributor

Thanks for fixing this in from inside the library.

@JakeWharton
Copy link
Member

Also worth noting the 23 character thing stopped being a thing in API 24.

@yschimke
Copy link
Collaborator Author

That still means that OkHttp MockWebServer 4.8 is broken for development testing on support versions. I'm pretty sure this is the only artifact, the runtime paths take care of this.

@yschimke yschimke changed the title Fix android logging with MockWebServer Fix android logging with MockWebServer on API 21-23 Aug 16, 2020
@yschimke yschimke added this to the 4.9 milestone Aug 17, 2020
@yschimke
Copy link
Collaborator Author

PR contribution in #6225

@yschimke
Copy link
Collaborator Author

Closing with #6229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in existing code
Projects
None yet
Development

No branches or pull requests

3 participants