Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Is it possible to update the comment with more info #8300

Closed
sarthak-greenely opened this issue Mar 20, 2024 · 1 comment
Closed

Comments

@sarthak-greenely
Copy link

sarthak-greenely commented Mar 20, 2024

client.dispatcher().executorService().shutdown();

Hello! Is it possible to get more clarity on what this line does?
As my initial thought is that it would completely stop any subsequent network request made via this OkHttpClient object? Was this line written for this particular sample where we are creating a new OkHttpClient object inside run()?
Also, for an application having a singleton OkHttpClient object, should this be called at all?

Thanks for reading!

@swankjesse
Copy link
Member

This might help?
#8328

@yschimke yschimke closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants