Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferedSink.write(Source, long) hides bugs #105

Closed
JakeWharton opened this issue Jan 5, 2015 · 1 comment · Fixed by #124
Closed

BufferedSink.write(Source, long) hides bugs #105

JakeWharton opened this issue Jan 5, 2015 · 1 comment · Fixed by #124
Labels
bug
Milestone
1.3

Comments

@JakeWharton
Copy link
Member

It calls source.read(buffer, byteCount) which might not read byteCount bytes and also might return -1 (which is ignored).

Our API should make it hard to write buggy code, and this one tripped me up forcing use of the inverse API which correctly reported read count.
@akhilc1
Copy link

akhilc1 commented Feb 9, 2015

Yeah, I got this issue regardless of whatever I give for byteCount only 2kb of data gets written/read

@swankjesse swankjesse added the bug label Feb 24, 2015
@swankjesse swankjesse added this to the 1.3 milestone Feb 24, 2015
@JakeWharton JakeWharton mentioned this issue Mar 7, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.3
Development

Successfully merging a pull request may close this issue.

Force write(Source, long) to write fully. square/okio
3 participants
@JakeWharton @swankjesse @akhilc1