Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 3.4.0 to fix CVE-2023-3635 also requires a Kotlin upgrade #1323

Closed
tyvumo opened this issue Aug 2, 2023 · 4 comments
Closed

Upgrade to 3.4.0 to fix CVE-2023-3635 also requires a Kotlin upgrade #1323

tyvumo opened this issue Aug 2, 2023 · 4 comments

Comments

@tyvumo
Copy link

tyvumo commented Aug 2, 2023

Scenario:
We are maintaining common libraries for our own and customer projects.
The dependencies are based on spring boot 2.7.14 as documented in https://docs.spring.io/spring-boot/docs/2.7.14/reference/html/dependency-versions.html .
We want to fix CVE-2023-3635 by upgrading Okio (and maybe Okhttp).

Expectations / Request:
We can fix CVE-2023-3635 without upgrading Kotlin in all dependent projects.
(Possibly unjustified Kotlin assumption: As long as we don't directly import Okio classes, linking should work as long as JVM versions are compatible.)

Observations:
Using Java, all seems fine.
In Kotlin code we get this error message:
[ERROR] /home/[...]/.m2/repository/com/squareup/okio/okio-jvm/3.4.0/okio-jvm-3.4.0.jar!/META-INF/okio.kotlin_module: (-1, -1) Module was compiled with an incompatible version of Kotlin. The binary version of its metadata is 1.8.0, expected version is 1.6.0.

Would id be possible to back-port the fix in 81bce1a to an Okio version before the Kotlin upgrade in 3.3.0?

@swankjesse
Copy link
Member

Can do.

@marcelstoer
Copy link

Looking forward to this as we're affected as well. As per https://square.github.io/okio/changelog/#version-320 3.2.0 is the latest not requiring Kotlin 1.8. Can we expect a 3.2.1 which addresses CVE-2023-3635 then? That would be fantastic!

@zangye
Copy link

zangye commented Aug 16, 2023

hello. when can you back-port the fix in 81bce1a to an Okio version before the Kotlin upgrade in 3.3.0?

@swankjesse
Copy link
Member

I’ve shipped Okio 1.17.6 that includes a fix for this and has no Kotlin dependency.

I don’t think it’s a good investment in our time to backport this fix for earlier Kotlin versions. Both Okio and the Kotlin stdlib have strong backwards compatibility, and you will be safe running on Okio 3.6.0 + Kotlin Stdlib 1.9.10 even if your build toolchain uses an earlier Kotlin release.

@swankjesse swankjesse closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants