Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the operators in the geometry additions have unclear behavior #32

Closed
NickEntin opened this issue Dec 17, 2020 · 1 comment · Fixed by #67
Closed

Some of the operators in the geometry additions have unclear behavior #32

NickEntin opened this issue Dec 17, 2020 · 1 comment · Fixed by #67
Labels
good first issue Good for newcomers
Milestone

Comments

@NickEntin
Copy link
Collaborator

NickEntin commented Dec 17, 2020

Specifically, we should convert the following operator overloads into methods to improve clarity around what their function is and what type they will return:

  • -(CGPoint, CGPoint) should be converted to CGPoint.offset(to:)
  • +(CGPoint, UIOffset) should be converted to CGPoint.offset(by:)
  • +(CGRect, UIOffset) should be converted to CGRect.offset(by:)
@NickEntin NickEntin added the good first issue Good for newcomers label Dec 17, 2020
@NickEntin NickEntin added this to the 1.0 milestone Dec 17, 2020
@NickEntin
Copy link
Collaborator Author

-(CGPoint, CGPoint) would actually be directly converted to CGPoint.offset(from:), but I think CGPoint.offset(to:) reads better. We could also potentially have both versions available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant