into() : Applying a Phrase to a TextView #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnjn
changed the title
|
|
||
| @Test public void testIntoNullFailsFast() { | ||
| try { | ||
| Phrase.from("Hello {user}!").put("user", "Eric").into(null); |
There was a problem hiding this comment.
You'll also want to fail if the exception is not thrown at all.
Ideally, all these tests should use @Rule ExpectedException.
There was a problem hiding this comment.
Good call, adding this in.
commit cfb46a06bc78d0c5b1112fa1ff6f19e8b3ade622 Merge: 4fbd68b 4efb923 Author: Quinn Neumiiller <quinnjn@gmail.com> Date: Thu Apr 9 16:13:48 2015 -0600 Better exception testing. commit 4fbd68b Author: Quinn Neumiiller <quinnjn@gmail.com> Date: Thu Apr 9 11:15:56 2015 -0600 Squashed commit of the following: commit 4efb923 Author: Quinn Neumiiller <quinnjn@gmail.com> Date: Thu Apr 9 11:15:35 2015 -0600 Adding usage to readme. commit 11f1039 Author: Quinn Neumiiller <quinnjn@gmail.com> Date: Thu Apr 9 10:50:04 2015 -0600 Adding into and tests. commit 4efb923 Author: Quinn Neumiiller <quinnjn@gmail.com> Date: Thu Apr 9 11:15:35 2015 -0600 Adding usage to readme. commit 11f1039 Author: Quinn Neumiiller <quinnjn@gmail.com> Date: Thu Apr 9 10:50:04 2015 -0600 Adding into and tests.
| @@ -166,4 +173,20 @@ public void formatFailsFastWhenKeysAreMissing() { | |||
| assertThat(formatted.toString()).isEqualTo("Hello Abe, you are 20 years old."); | |||
| assertThat(formatted).isInstanceOf(Spannable.class); | |||
| } | |||
|
|
|||
| @Test public void testIntoSetsTargetText() { | |||
|
Merged separately w/ feedback applied. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting text directly from the Phrase chain, similar to how Picasso does it.
Before:
Now: