Prevent PicassoExecutorService race condition in DispatcherTest #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afollestad
approved these changes
Nov 9, 2022
| private val bitmap1 = makeBitmap() | ||
|
|
||
| @Before fun setUp() { | ||
| initMocks(this) | ||
| `when`(context.applicationContext).thenReturn(context) | ||
| doReturn(mock(Future::class.java)).`when`(executorService).submit(any(Runnable::class.java)) |
There was a problem hiding this comment.
Do you guys not bring in Mockito Kotlin?
There was a problem hiding this comment.
not at the moment, cuz we'd like to remove all mocks, but that will take a bit of refactoring to achieve.
jrodbx
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been seeing a pattern of flaky DispatcherTests along the lines of
With the debugger I was able to see that PicassoExecutorService is actually spinning up a new thread and executing / completing before our test asserts causing the failure / race condition. Tried swapping PicassoExecutorService out but its required for some tests, so using a spy to prevent creating / executing other threads.