Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJava update breaks Retrofit #464

Closed
hamen opened this issue Apr 23, 2014 · 3 comments
Closed

RxJava update breaks Retrofit #464

hamen opened this issue Apr 23, 2014 · 3 comments

Comments

@hamen
Copy link

hamen commented Apr 23, 2014

Hi
Just a tip. Netflix just released RxJava 0.18.0. It contains a major change to Schedulers and breaks Retrofit 1.5.0. We are currently specifying RxJava previous version to be able to use Retrofit:

dependencies {
    compile 'com.netflix.rxjava:rxjava-core:0.17.6'
    compile 'com.netflix.rxjava:rxjava-android:0.17.6'
    compile 'com.squareup.retrofit:retrofit:1.5.0'
}
@jdreesen
Copy link
Contributor

This is the corresponding PR where the ExecutorScheduler, which is used by Retrofit, was removed: RxJava#1048

@chrisjenx
Copy link
Contributor

Yeah, I will have a gander into this later, Although not sure how the Square guys want to approach this.

Basically it more or less needs to be a EventLoopsScheduler using the Executor pool from Retrofit.

@chrisjenx
Copy link
Contributor

See #468, I have sent a PR for review, I tried to keep impl as simple as possible. Although as this is quite a big API change. It probably needs a quick discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants