Avoid Math.sqrt() in ShakeDetector #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,8 +91,9 @@ private boolean isAccelerating(SensorEvent event) { | |||
| float ay = event.values[1]; | |||
| float az = event.values[2]; | |||
|
|
|||
| final double magnitude = Math.sqrt(ax * ax + ay * ay + az * az); | |||
| return magnitude > ACCELERATION_THRESHOLD; | |||
| // Avoid Math.sqrt(). | |||
There was a problem hiding this comment.
This comment is not useful as-is. Either remove it or say something like the first sentence of this PR description.
|
Looks good. Can you sign our CLA so that I can merge this? |
|
Done. |
|
Squashed and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given both
magnitudeandACCELERATION_THRESHOLDare positive, the following are equivalent:The second one is more efficient.