Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

Port to RxJava 2. #183

Merged
merged 1 commit into from
Jun 4, 2017
Merged

Port to RxJava 2. #183

merged 1 commit into from
Jun 4, 2017

Conversation

JakeWharton
Copy link
Member

  • Maven groupId is now com.squareup.sqlbrite2.
  • Package name is now com.squareup.sqlbrite2.
  • Query.mapTo* methods now return ObserverOperator instead of Function for use with lift instead of to.
  • Backpressure is no longer supported and must be applied with operators.

Closes #136

@JakeWharton JakeWharton force-pushed the jw/2017-06-04/too branch 2 times, most recently from 39cbbbc to e551366 Compare June 4, 2017 17:37
@JakeWharton
Copy link
Member Author

Lint just spins on the sample. Not sure why...

@iNoles
Copy link

iNoles commented Jun 4, 2017

You could have put checkReleaseBuilds false or abortOnError false under lintOptions block.

@JakeWharton
Copy link
Member Author

checkReleaseBuilds has no effect, this is the lint task that's running. abortOnError also has no effect as the lint task never completes.

@JakeWharton
Copy link
Member Author

Besides, adding either of those is not correct here.

@JakeWharton JakeWharton force-pushed the jw/2017-06-04/too branch 4 times, most recently from 74ef6b4 to 448bfe2 Compare June 4, 2017 20:46
@albodelu
Copy link

albodelu commented Jun 4, 2017

As a quick fix, you can try to increase travis_wait (10 minutes by default) to 20 minutes.

This bash function is discussed here and documented here.

You need to add the default script section to .travis.yml like this:

script:
  - travis_wait 20 ./gradlew build connectedCheck

travis_wait is not the better solution because it shows a green build result when a test fails, due to the travis_wait command finishes successfully.

It's only to see what does under the hood.

A better solution would be to try to decrease the requited time or to print something every 8 minutes like this.

# Print delayed 8 minutes
# Print and return the text of this script delayed
function print-delayed {
    sleep 480
    print-mytext "`echo "\n"`"
}

I use it like this:

script:
  - ./execute print-delayed & # Print script text delayed 8 minutes to avoid travis timeout
  - ./gradlew build connectedCheck

A Gradle task would be better in your case, this is only a dirty workaround.

@JakeWharton
Copy link
Member Author

I let it run for 30m locally. It's not a problem with Travis as it should complete in a few seconds. Reverting the Android Gradle plugin update fixed it until we can jump to 3.0.

* Maven groupId is now `com.squareup.sqlbrite2`.
* Package name is now `com.squareup.sqlbrite2`.
* `Query.mapTo*` methods now return `ObserverOperator` instead of `Function` for use with `lift` instead of `to`.
* Backpressure is no longer supported and must be applied with operators.
@JakeWharton JakeWharton merged commit 9b0856d into master Jun 4, 2017
@JakeWharton JakeWharton deleted the jw/2017-06-04/too branch June 4, 2017 21:05
@arazabishov
Copy link

arazabishov commented Jun 5, 2017

@JakeWharton Is there any particular reason not to use Flowable as a main building block for SqlBrite?

@JakeWharton
Copy link
Member Author

JakeWharton commented Jun 5, 2017 via email

@arazabishov
Copy link

arazabishov commented Jun 5, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants