-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dSYM not included in Framework zip #58
Comments
It does seem possible. Carthage's README explains how. I can get to this in a couple weeks, but if you'd like to add this functionality before I get there feel free. FWIW, I have never seen Valet crash in the wild (hopefully you haven't either!) |
Thanks @dfed, we haven't either! It just caught us out, because if we build from scratch it includes the dSYM, and copying it over is one of our build phases. Happy to give you a new zip to replace the existing one, if you like? |
Thanks for the offer! Unfortunately, I can't vend a |
This should be the default (with carthage 0.10):
This also creates the currently missing bitcode files (as we discussed at length on twitter). |
@mgroh so if I update my local carthage tool, then build/release a new version, everything should work? |
Just updated the .framework on the 2.0.6. Same code, but now built with carthage 0.10. Please let me know if this fixes the above issue. If it does, I'll close this issue out. |
Yes, the release .zip now includes the .dSYM and .bcsymbolmap files. |
Awesome. Thanks for the help! Closing this issue out |
I noticed that the dSYM is not included in the framework zip that Carthage downloads. We like to include those in the Build Products folder, so we get full backtraces. Is it possible to include it?
The text was updated successfully, but these errors were encountered: