Decode grpc-status-details-bin and add it to GrpcException #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only attempt to base64-decode it when there's no transport error. An invalid base64 value will be treated as IOException. It is up to the user to unmarshal it into a string if desired. This is a de-facto standard used by grpc: https://groups.google.com/g/grpc-io/c/p_gCk1bn2JE Note that this is *not* included into `responseMetadata` because gRPC metadata must not include reserved names `grpc-*` per spec: https://grpc.io/docs/what-is-grpc/core-concepts/#metadata In other words, by definition this is not "metadata". Fixes square#2343.
|
Thanks @Hexcles , you think you could write a test for this? |
|
Definitely. I was going to ask if there's a development setup doc. I keep
running into weird issues (like xcrun returning 1, schema not found, etc.).
…---
Sent from my cellphone.
On Fri, Nov 18, 2022, 03:40 Benoît Quenaudon ***@***.***> wrote:
Thanks @Hexcles <https://github.com/Hexcles> , you think you could write
a test for this?
—
Reply to this email directly, view it on GitHub
<#2352 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK6ZDBSAR7YT24JHFRLBI3WI46HFANCNFSM6AAAAAASD2UP7A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
We do not have a dev setup doc unfortunately. It's been a pain to build Wire for a while specially since we went MPP + included projects. We'll flatten the project soon which should help some of those hopefully. For the xcrun stuff I don't recall. Might need to install the Xcode Command Line Tools. |
|
Replaced by #2408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only attempt to base64-decode it when there's no transport error. An invalid base64 value will be treated as IOException.
It is up to the user to unmarshal it into a string if desired.
This is a de-facto standard used by grpc:
https://groups.google.com/g/grpc-io/c/p_gCk1bn2JE
Note that this is not included into
responseMetadatabecause gRPC metadata must not include reserved namesgrpc-*per spec: https://grpc.io/docs/what-is-grpc/core-concepts/#metadata In other words, by definition this is not "metadata".Fixes #2343.