Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComposeViewFactory isn't currently compatible with saved instance state #295

Open
zach-klippenstein opened this issue Jun 4, 2020 · 0 comments
Open

ComposeViewFactory isn't currently compatible with saved instance state #295

zach-klippenstein opened this issue Jun 4, 2020 · 0 comments
Labels
compose

Comments

@zach-klippenstein
Copy link
Collaborator

AndroidComposeView requires its parent view to have an ID to support saved state registry, but we have the same problem that it does – they're creating dynamically, and we can't guarantee a unique ID across process restarts. Not sure how to solve this, this ticket is for exploring possible solutions.

One idea might be to require bindCompose composedViewFactory to take an @IdRes Int.

Some related Compose links:
@zach-klippenstein zach-klippenstein transferred this issue from square/workflow-kotlin-compose Feb 4, 2021
@zach-klippenstein zach-klippenstein added bug Something isn't working compose and removed bug Something isn't working labels Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compose
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zach-klippenstein