Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kotlin] Stacktraces from WorkflowTester timeouts are useless #761

Open
zach-klippenstein opened this issue Feb 7, 2020 · 3 comments
Open

[kotlin] Stacktraces from WorkflowTester timeouts are useless #761

zach-klippenstein opened this issue Feb 7, 2020 · 3 comments
Labels
bug Something isn't working kotlin

Comments

@zach-klippenstein
Copy link
Collaborator

zach-klippenstein commented Feb 7, 2020 •
edited

Timeout exceptions thrown from the coroutine library's withTimeout function are useless. We should catch and re-throw with a real exception that has a real stacktrace.
@zach-klippenstein zach-klippenstein added the bug Something isn't working label Feb 7, 2020
@zach-klippenstein
Copy link
Collaborator Author

The comment on this issue makes it sound like this should be fixed already, but apparently it is not: Kotlin/kotlinx.coroutines#1625 (comment)

@zach-klippenstein
Copy link
Collaborator Author

Since it affects which exceptions we expose, I would consider this as an API change even though it's technically not.

@zach-klippenstein
Copy link
Collaborator Author

Not API change, not 1.0 blocker.

@rjrjr rjrjr transferred this issue from square/workflow May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working kotlin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zach-klippenstein @JustinDSN