Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom share operator from terminal sample when it lands in the coroutines lib #774

Open
rjrjr opened this issue Jul 9, 2019 · 0 comments

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Jul 9, 2019

Unfortunately, we had to write a custom share operator for the keystroke flow, since the keystroke worker is used by two separate workflows simultaneously, and without it they each get alternating keystrokes. There is an issue open on the coroutines project to implement a standard operator (Kotlin/kotlinx.coroutines#1261).

Originally posted by @zach-klippenstein in square/workflow@1912d58

@zach-klippenstein zach-klippenstein changed the title Remove custom share operator from terminal sample when https://github.com/Kotlin/kotlinx.coroutines/issues/1261 is addressed. Remove custom share operator from terminal sample when it lands in the coroutines lib Jul 9, 2019
@zach-klippenstein zach-klippenstein added the enhancement New feature or request label Jul 9, 2019
@rjrjr rjrjr transferred this issue from square/workflow May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants