Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace receiveOrNull with receiveOrClosed once released. #773

Open
zach-klippenstein opened this issue Jul 31, 2019 · 2 comments
Open

Replace receiveOrNull with receiveOrClosed once released. #773

zach-klippenstein opened this issue Jul 31, 2019 · 2 comments
Labels
blocked enhancement New feature or request kotlin

Comments

@zach-klippenstein
Copy link
Collaborator

Starting in 1.3.0-RC, receiveOrClosed exists – however it's marked as @InternalCoroutinesApi. There are plans to make it public, but it's blocked by inline class stability (Kotlin/kotlinx.coroutines#1343 (comment)).
@zach-klippenstein zach-klippenstein added enhancement New feature or request blocked labels Jul 31, 2019
@zach-klippenstein zach-klippenstein mentioned this issue Jul 31, 2019
Merged
zach-klippenstein referenced this issue in square/workflow Jul 31, 2019
@zach-klippenstein
Upgrade coroutines to latest version (1.3.0-RC).
19cb2b6 
This is the first version of the library in which `receiveOrClosed` is available, but it's still internal. See #512.

Changelog: https://github.com/Kotlin/kotlinx.coroutines/releases/tag/1.3.0-rc
zach-klippenstein referenced this issue in square/workflow Sep 3, 2019
@zach-klippenstein
Remove runningWorkerUntilFinished.
e48ae69 
Closes #558, removes 1/2 of #512 TODOs, and closes #434.
@zach-klippenstein zach-klippenstein mentioned this issue Sep 3, 2019
Merged
zach-klippenstein referenced this issue in square/workflow Sep 3, 2019
@zach-klippenstein
Remove runningWorkerUntilFinished.
e2082f1 
Closes #558, removes 1/2 of #512 TODOs, and closes #434.
@zach-klippenstein
Copy link
Collaborator Author

Tried using the preview version of receiveOrClosed, but turns out it's broken (Kotlin/kotlinx.coroutines#1584) and caused a set of bugs with odd stacktraces (#626).

@zach-klippenstein
Copy link
Collaborator Author

The referenced coroutines bug was fixed some time ago. Might want to give this another try.

@steve-the-edwards steve-the-edwards mentioned this issue May 13, 2021
Merged
@rjrjr rjrjr transferred this issue from square/workflow May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked enhancement New feature or request kotlin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zach-klippenstein @JustinDSN