Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check model monitor's status before creating alerts #80

Closed
sinnec opened this issue Dec 30, 2022 · 1 comment · Fixed by #82
Closed

Check model monitor's status before creating alerts #80

sinnec opened this issue Dec 30, 2022 · 1 comment · Fixed by #82
Assignees
@sinnec
Labels
bug Something isn't working

Comments

@sinnec
Copy link
Contributor

sinnec commented Dec 30, 2022

Currently the status of a monitor (active/inactive) isn't checked before running the checks for alert creation so even if a monitor is inactive it can create an alert.

Suggested Solutions:

  • Check for the monitor's status before creating the alerts OR
  • Fetch only active monitors from the database in alerts pipeline.
@stavrostheocharis
Copy link
Contributor

Fetch only active monitors from the database in alerts pipeline.

@stavrostheocharis stavrostheocharis added the bug Something isn't working label Jan 2, 2023
@sinnec sinnec mentioned this issue Jan 2, 2023
Merged
@sinnec sinnec closed this as completed in #82 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sinnec sinnec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check model monitor's status before alert pipeline squaredev-io/whitebox
2 participants
@sinnec @stavrostheocharis