Error pending confirmation callbacks on channel close #498
Conversation
This allows the package to be installed directly from git
|
This makes sense. It is a behaviour change though -- people may not be prepared for rejections from waitForConfirms (though I hope they would be). I guess we can call that out in release notes when it comes to it. The tests are failing because of some ES6 syntax which snuck in channel.js L36 (honestly, if I had the time I'd rewrite in ES6 and babel it for older runtimes ..). |
|
While I understand the behavior change I think the current behavior is worse as messages won’t be acknowledged (the channel is closed) so the promise will never resolve and leave the process just hanging, which seems more like a bug. Afaik you already need to handle the reject case anyway as messages could be rejected for other reasons, not? Will fix the es6 syntax, which node versions are currently supported? |
Absolutely -- in this case the risk is people relying too much on the "happy path", so I'm not too troubled by it.
All the way back to Node 0.8. (!) |
Otherwise waitForConfirms never terminates or terminates node
johanneswuerbach
force-pushed
the
error-unacked-on-close
branch
from
fd52a85
to
16439ea
Compare
|
@squaremo tests fixed. |
|
@squaremo friendly ping :-) |
|
Maybe @cressie176? Sorry for the spam, but installing this dependency from git requires curl, which is a bit of a bummer :-( |
|
Sorry @johanneswuerbach, I don't always get a lot of time to react to PRs and issues -- but at least you've made it easy for me by explaining the motivation and keeping the change simple |
|
@squaremo sure, no worries. As an open source maintainer myself I completely understand, let me know if there is anything I can do to help. |
Otherwise waitForConfirms never terminates or terminates node
Additional this includes a commit 099673e, which makes it possible to install this module directly from git (instead of the published package), but I'm happy to drop this if preferred.