Close connection to server on connect errors #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luddd3
force-pushed
the
connect-error
branch
from
6b525bb
to
940ca2f
Compare
|
Never heard of the concept of bike shedding? :D |
luddd3
force-pushed
the
connect-error
branch
from
940ca2f
to
9ddfb7b
Compare
|
@kibertoad Sorry for pinging, but I saw in another thread that you do some work in this repo. Can you please review this PR too? |
kibertoad
approved these changes
Dec 28, 2021
|
Thank you! |
|
@luddd3 CI is failing on main now, could you please take a look? |
|
@kibertoad Fixed in #667 |
This was referenced May 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minimal pull request to fix open socket leak after e.g. authentication error on connect. This is a part of the fix in #584, but I have only kept the most essential part and added a test.
By keeping this as small as possible, I hope to remove any hesitance so that it can be merged.