Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔒 amqplib will use the security patched version of urlpar… #675

Merged
merged 2 commits into from
Mar 20, 2022

Conversation

suhail-n
Copy link
Contributor

@suhail-n suhail-n commented Mar 20, 2022

Overview

The current url-parse version 1.5.3 has the following critical vulnerabilities CVE-2022-0691, and CVE-2022-0686

Security Patch

  • Updated url-parse to version 1.5.10

EDIT

After making changes, the CI build was failing. This was occurring because the configured workflow was attempting to install rabbitmq manually using sudo apt-get install rabbitmq-server -y --fix-missing. I replaced it with the service container for rabbitmq.

Before using an install command in under steps:

steps:
- name: Install rabbitmq
      run: |
        sudo apt-get install rabbitmq-server -y --fix-missing

After removing steps and using a service container:

jobs:
  build:
    runs-on: ubuntu-latest
    services:
# using rabbitmq:latest image
      rabbitmq:
        image: rabbitmq
        ports:
          - 5672:5672

…5.10

- updated url-parse to the latest version to resolve security CVE-2022-0691, and CVE-2022-0686
@kibertoad kibertoad merged commit b4943cd into amqp-node:main Mar 20, 2022
@kibertoad
Copy link
Collaborator

Thanks a lot!

@kibertoad kibertoad mentioned this pull request Mar 20, 2022
@kibertoad
Copy link
Collaborator

@cressie176 @squaremo We need to publish a new patch version with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants