Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion - Extract images #26

Closed
stephen147 opened this issue Jun 18, 2021 · 9 comments
Closed

Suggestion - Extract images #26

stephen147 opened this issue Jun 18, 2021 · 9 comments

Comments

@stephen147
Copy link

There's currently a way to remove them.

Would it be possible to add an extraction to the current folder for the embedded images also?

@squell
Copy link
Owner

squell commented Jun 19, 2021

The simplistic id3-images program (https://github.com/squell/id3/blob/master/id3-images.c) should do exactly that. make all or make id3-images should build it without problems.

For some reason it was not provided as a binary in the binary distributions in 2015, that should probably change.

@stephen147
Copy link
Author

Thanks. What version of Visual Studio does that require. I'm only starting out with it.

Does that only support MP3s'? I was hoping for FLAC also.

@squell
Copy link
Owner

squell commented Jul 9, 2021

I think the last binary for Windows could compile with both VisualStudio 2010 and 2012. But any version should be fine.

(If you find a reasonable compiler+system combo that doesn't compile id3-images.c, that is something you can open an issue for---it's intended to be reasonably portable.)

Edit
I should add that if you compile with with MSVC, you may need to find a dirent.h file (unless newer versions of MSVC include it). I'd think this one works fine: https://github.com/tronkko/dirent/blob/master/include/dirent.h

and you should be able to use nmake /f makefile.nmk to compile (or you can create your own project file in the IDE). And do read the INSTALL file under the section 'building manually', which has this info too :-)

@squell
Copy link
Owner

squell commented Jul 9, 2021

And no, while technically id3 will happily tag FLAC files with ID3 tags and I can imagine some software will read them, that should be discouraged since FLAC has its own metadata format that surely is better.

It's not a bad suggestion to add support for that though.

@stephen147
Copy link
Author

I'll leave building it as I was hoping for FLAC and MP3 support. Hopefully, someday you can find the time to add this to the program and compile it for use as I'm sure a lot of people would take advantage of it.

Thanks.

@squell squell closed this as completed Feb 17, 2023
@stephen147
Copy link
Author

Thanks, when will this be available in the release downloads?

@squell
Copy link
Owner

squell commented Jun 30, 2023

When 0.81 comes out, which will be soon (building it on Windows might take some more time); I finally have some time again to do maintenance on this. :)

@stephen147
Copy link
Author

Thanks. Will there be a method to retrieve whether or not it has an image so it can be exported? I guess that'll be wrapped in the new export fn?

@squell
Copy link
Owner

squell commented Jun 30, 2023

https://github.com/squell/id3/releases/download/0.81/id3-081w.zip should contain a workable id3-images (compiled using a Windows 11 development image, so I'm hoping it also works on older Windows platforms, if not I'll recompile later when I get my hands on a Windows machine again).

There's no check whether the file has an image; you can just run id3-images on a file and it should extract them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants