Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Search hotkey does not work in tablet view #1067
Pressing "S" in tablet screen size does not open the search overlay. It will focus the hidden search field instead and write into it, as you can see when resizing to screen size. This can be reproduced on the demo page and happens in chrome and firefox.
Reproduction: Go to the demo page, resize screen to tablet size, type "stest", resize to screen size.
Revisiting the source code it's clear that this was initially done by design - the search should not be triggerable by hotkey if the search bar was not visible. However, the focus did actually execute, leaving the user in the invalid state in which search was not visible but focused.
8049185 removes the breakpoint guard for the hotkeys, so search does now consistently trigger on hotkeys for all screen sizes.