Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search hotkey does not work in tablet view #1067

Closed
ghost opened this issue Apr 10, 2019 · 3 comments
Closed

Search hotkey does not work in tablet view #1067

ghost opened this issue Apr 10, 2019 · 3 comments

Comments

@ghost
Copy link

@ghost ghost commented Apr 10, 2019

Description

Pressing "S" in tablet screen size does not open the search overlay. It will focus the hidden search field instead and write into it, as you can see when resizing to screen size. This can be reproduced on the demo page and happens in chrome and firefox.

Reproduction: Go to the demo page, resize screen to tablet size, type "stest", resize to screen size.

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Apr 11, 2019

That is in fact correct. ESC seems to work. Shouldn't be too hard to fix.

@squidfunk squidfunk added the bug label Apr 11, 2019
@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Apr 28, 2019

Revisiting the source code it's clear that this was initially done by design - the search should not be triggerable by hotkey if the search bar was not visible. However, the focus did actually execute, leaving the user in the invalid state in which search was not visible but focused.

8049185 removes the breakpoint guard for the hotkeys, so search does now consistently trigger on hotkeys for all screen sizes.

@squidfunk
Copy link
Owner

@squidfunk squidfunk commented Apr 28, 2019

Released as part of 4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant