Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table of contents items sometimes don't blur on fast scrolling #117

Closed
max-ci opened this issue Jan 17, 2017 · 8 comments
Closed

Table of contents items sometimes don't blur on fast scrolling #117

max-ci opened this issue Jan 17, 2017 · 8 comments
Assignees
Labels
bug Issue reports a bug
Milestone

Comments

@max-ci
Copy link

max-ci commented Jan 17, 2017

Description

When I scroll through the documentation up and down some items in table of contents are not blurring (not always), also I'm not sure if states are updating on resize.

Scrollfix

Expected behavior

Properly blurred elements

Actual behavior

Items are not blurring properly when scrolling up and down

Steps to reproduce the bug

  1. Open for example release notes (demo page)
  2. Scroll up and down (fast enough) to see that some items are not blurring

Package versions

  • MkDocs: 0.16.1
  • Material: 1.0.2

System information

  • OS: MacOS
  • Browser: Chrome/Firefox

This is a problem for me because I would like to always show only one expanded menu in table of contents (to save some space).

Suggestion Bootstrap documentation approach (I think it is a lot easier to determine where I'm on the site when I see active state of current elements rather than blurred scrolled elements. Also, it's nice that they show only one 2nd level menu at a time.

Here is also a cool idea.

I like your idea with blurring elements and how it looks/animate when I scroll, but I think it's not that good for end user experience.

@squidfunk
Copy link
Owner

The scrollfix is something else - it's targeted at the iPhone. You should not use this attribute for styling, as it is totally unrelated to blurring. However, I will look into the blurring when I find the time.

The link you posted is in my opinion too distracting. I tried to make it as light as possible, so it doesn't get a lot of intention, because it's unimportant while scrolling - in my opinion the information is only needed when the user looks explicitly for the TOC.

@max-ci
Copy link
Author

max-ci commented Jan 17, 2017

I meant data-md-state="blur" instead of scrollfix. Can I use this to style elements?

@squidfunk
Copy link
Owner

Sure, it's related to the thing you're trying to accomplish.

@squidfunk squidfunk changed the title Scrollfix is not working properly (table of contents nav) Table of contents items sometimes don't blur on fast scrolling Jan 17, 2017
@squidfunk
Copy link
Owner

I tried to reproduce this yesterday but did not manage to. Can you provide a more detailed instruction how to reproduce?

@max-ci
Copy link
Author

max-ci commented Jan 18, 2017

It's nothing special. I'm just opening your demo page and start scrolling, what I noticed is that it always works properly when I scroll for the first time (scroll speed doesn't matter). You can even try it with moving browser scrollbar clicking it and moving mouse up and down. I tried this on Chrome and Firefox (on Firefox it's better, it occurs only when I try to scroll using browser scrollbar instead of mouse wheel).

Video link

@squidfunk
Copy link
Owner

Managed to reproduce it scrolling with the scrollbar - not really used to on the Mac. Will provide a fix.

@squidfunk squidfunk self-assigned this Jan 18, 2017
@squidfunk squidfunk added the bug Issue reports a bug label Jan 18, 2017
@squidfunk squidfunk added this to the 1.0.3 milestone Jan 18, 2017
@squidfunk
Copy link
Owner

squidfunk commented Jan 22, 2017

Fixed in master with 32ffc58. As soon as you confirm your bug fixed, I can release 1.0.3.

@max-ci
Copy link
Author

max-ci commented Jan 22, 2017

It's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug
Projects
None yet
Development

No branches or pull requests

2 participants