Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image links have a red underline #21

Closed
d0ugal opened this issue Mar 19, 2016 · 3 comments
Closed

Image links have a red underline #21

d0ugal opened this issue Mar 19, 2016 · 3 comments
Assignees
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Milestone

Comments

@d0ugal
Copy link

d0ugal commented Mar 19, 2016

Images that are links have a red underline which only really makes sense for text. This can be recreated if you use a simple example like this to add a badge to documentation.

[![PyPI Downloads][pypi-dl-image]][pypi-dl-link]
[pypi-dl-image]: https://img.shields.io/pypi/dm/retrace.png
[pypi-dl-link]: https://pypi.python.org/pypi/retrace

See it live here.

@squidfunk
Copy link
Owner

Hmm, that's a bug that is not possible to fix with plain CSS using the HTML that got generated by the Markdown parser, as all a nodes that don't have a img node cannot be selected with current CSS selectors. It will be possible in CSS4, but that's still in draft.

I added the dotted line due to links disappearing in admonition notes (see issue #7), so it was more of a quick fix. I will reconsider how we handle links in the refactoring I'm currently doing. So for now, I can't fix this issue, I'm sorry.

@squidfunk squidfunk added the bug Issue reports a bug label Mar 19, 2016
@squidfunk squidfunk added this to the 0.3.0 milestone Mar 19, 2016
@squidfunk squidfunk self-assigned this Mar 19, 2016
@d0ugal
Copy link
Author

d0ugal commented Mar 19, 2016

Don't worry or rush, it is only a minor glitch that I thought I would report. 😄

@squidfunk
Copy link
Owner

Fixed in upcoming 1.0.0, see #46. Issue will remain open until release.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants