-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental search highlighting and search sharing feature fails #2853
Comments
Looks like both of these are Insiders only or Exclusive features available to sponsors-only! |
That’s correct, currently both features are reserved to sponsors 😊 |
@squidfunk How did I then have access to Search suggestions feature even before Biquinho Vermelho is met? Perhaps, there's an unintended leak? 🤔 |
I mean, auto-suggest (the drop-down list) as compared to auto-complete. |
Yeah, search suggestions are auto-complete, so maybe it's just confusing wording. |
Perhaps, this image would help. |
It would be incorrect, because we're not rendering search suggestions below the search bar, but search results, i.e. the actual documents. |
With the help of my awesome sponsors, I'm happy to tell you that we just reached the funding goal which will release those three features into the wild. Expect 7.2 within the next days, including all features from Biquinho Vermelho |
Awesome! |
7.2.0 was just released. |
Thanks, @squidfunk -- that works! |
Contribution guidelines
I've found a bug and checked that ...
mkdocs
orreadthedocs
themescustom_dir
,extra_javascript
andextra_css
Description
The search plugin's experimental features
search.highlight
andsearch.share
don't seem to work as intended.Expected behaviour
mark
tag around each search result which would eventually be highlighted either usingPygments
orhighlight.js
. I even tried disablingCodeHilite
in favor of theHighlight
extension withSuperfences
extension along withmermaid2
's custom fences but it didn't seem to work as intended.Actual behaviour
mark
tag not added.Steps to reproduce
Take a look at this commit.
Package versions
Configuration
https://github.com/dangiankit/kgtk/commit/2697d638c1a8e5b844872803d8bdce3d15aa933d
System information
The text was updated successfully, but these errors were encountered: