New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing theme configuration file #519

Closed
facelessuser opened this Issue Oct 20, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@facelessuser
Contributor

facelessuser commented Oct 20, 2017

Description

Mkdocs material does not have a mkdocs_theme.yml. I run my mkdocs build with strict in Travis to catch whether my mkdocs environment has warnings etc. It is currently failing because of this. This is due to the mkdocs 0.17 release.

WARNING - The theme 'material' does not appear to have a configuration file. Please upgrade to a current version of the theme.

An example theme config: https://github.com/mkdocs/mkdocs/blob/master/mkdocs/themes/mkdocs/mkdocs_theme.yml

Not sure if any options need to be specified in it. Probably more that it is missing, but maybe we need to specify something in it. Not sure yet.

It's not a critical issue, but it should probably get added for correctness.

Expected behavior

Material should not generate warnings.

Actual behavior

Is generating the warning that the config file is not found.

Steps to reproduce the bug

  1. Build with strict: mkdocs build --clean --verbose --strict

Package versions

  • Python: Any
  • MkDocs: 0.17
  • Material: Any

Project configuration

NA

System information

  • OS: ANY
  • Browser: NA
@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Oct 20, 2017

Owner

Thanks for reporting. 0.17 also broke the search. Will provide a configuration file asap.

Owner

squidfunk commented Oct 20, 2017

Thanks for reporting. 0.17 also broke the search. Will provide a configuration file asap.

@squidfunk squidfunk self-assigned this Oct 21, 2017

@squidfunk squidfunk added the bug label Oct 21, 2017

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Oct 22, 2017

Owner

Should be fixed in master. Can you verify please? I've some problems with getting 0.17 to work locally, probably messed up my Python installation.

Owner

squidfunk commented Oct 22, 2017

Should be fixed in master. Can you verify please? I've some problems with getting 0.17 to work locally, probably messed up my Python installation.

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Oct 22, 2017

Owner

There are some fundamental changes with 0.17. Hope we'll get everything to work, but I will probably do 2.0.0 with breaking changes.

Owner

squidfunk commented Oct 22, 2017

There are some fundamental changes with 0.17. Hope we'll get everything to work, but I will probably do 2.0.0 with breaking changes.

@facelessuser

This comment has been minimized.

Show comment
Hide comment
@facelessuser

facelessuser Oct 22, 2017

Contributor

Sounds good! I expect some breaking changes as we approach mkdocs 1.0.

Contributor

facelessuser commented Oct 22, 2017

Sounds good! I expect some breaking changes as we approach mkdocs 1.0.

@squidfunk

This comment has been minimized.

Show comment
Hide comment
@squidfunk

squidfunk Oct 22, 2017

Owner

Released with 1.12.1

Owner

squidfunk commented Oct 22, 2017

Released with 1.12.1

@squidfunk squidfunk closed this Oct 22, 2017

@ghost ghost referenced this issue Nov 15, 2017

Closed

mkdocs server throws an error #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment