Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit on github button missing #5261

Closed
4 tasks done
veghdev opened this issue Mar 26, 2023 · 3 comments
Closed
4 tasks done

edit on github button missing #5261

veghdev opened this issue Mar 26, 2023 · 3 comments
Labels
resolved by config change Issue can be mitigated by the reporter

Comments

@veghdev
Copy link

veghdev commented Mar 26, 2023

Context

  • using latest (9.1.4) mkdocs-material theme
  • using latest (1.4.2) material
  • setting repo_url and edit_uri in mkdocs.yml

Bug description

With material theme edit on github button is missing from the generated page.
With same configuration and with other themes (mkdocs, readthedocs) it works.
I've attached a minimal sample and config to reproduce.

Related links

Reproduction

mkdocs-material-edituri-main.zip

Steps to reproduce

  • make dev
  • make doc

Browser

Chrome

Before submitting

@squidfunk
Copy link
Owner

squidfunk commented Mar 26, 2023

Thanks for reporting. It seems you upgraded recently to version 9, which makes the edit button opt-in. When upgrading major versions you should always read the upgrade guide, specifically this. You need the following setting:

theme:
  features:
    - content.action.edit

Edit: corrected setting.

@squidfunk squidfunk added the resolved by config change Issue can be mitigated by the reporter label Mar 26, 2023
@veghdev
Copy link
Author

veghdev commented Mar 26, 2023

Thanks. I missed it.
If someone else finds this issue, the right setting is:

theme:
  features:
    - content.action.edit

@squidfunk
Copy link
Owner

Oops, you're right. Corrected my initial answer 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolved by config change Issue can be mitigated by the reporter
Projects
None yet
Development

No branches or pull requests

2 participants