Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vscode remote dev container support #5454

Merged
merged 1 commit into from
May 2, 2023

Conversation

prnam
Copy link
Contributor

@prnam prnam commented May 1, 2023

Adds VS Code remote dev container support for those developers who use VS Code and containers for development.

  • It is configures to create container with Nodejs 18 LTS & Python 3.11
  • Post creation of the container it executes the essential commands in environment setup and build it, thus enabling quick and easy way to get everything setup for new contributors without context switching.

@squidfunk
Copy link
Owner

Thanks for the PR! Honestly, I'm not feeling comfortable maintaining this, because none of us maintainers uses dev containers. Are you up for maintaining this configuration for the time to come? If so, we can merge it. Additionally, could you please clean up the source files? There are a lot of commented out lines that seem very generic.

@prnam
Copy link
Contributor Author

prnam commented May 2, 2023

I can maintain it.

Comments are removed, @squidfunk.

@prnam prnam force-pushed the feature/add-remotedev-support branch from 783619c to a9d8eab Compare May 2, 2023 08:22
@squidfunk
Copy link
Owner

Thanks! Yes, let's remove them. Folks who are using dev containers should consult the dev containers documentation, as commented-out is not executed and thus just rots ☺️ LGTM!

@squidfunk squidfunk merged commit 32b7ee9 into squidfunk:master May 2, 2023
3 checks passed
@prnam prnam deleted the feature/add-remotedev-support branch May 2, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants