Update "Check Docker image" build step to handle upper case chars in repo names #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an error on the "Check Docker image" build step for any forks under GitHub users with an upper case character in their GitHub username.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5503 describes an issue where the "Check Docker image" build step throws an error when the build action runs on a fork owned by a user with one or more upper case characters in their name.
This PR handles this by assigning the value of
github.event.repository.full_nameto an environment variable, and then referencing that variable when callingdocker runusing bash parameter expansion to convert characters to lower case.The reason the build doesn't fail earlier in the job is because docker/metadata-action automatically converts image names to lower case.