Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation updates #56

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Conversation

brendo
Copy link
Contributor

@brendo brendo commented Oct 12, 2016

Hope you don't mind, but I thought this might pay forward in some small way to #46!

  • Removed reference to bower as it's no longer part of the process
  • Couple of newlines as per .editorconfig

@squidfunk
Copy link
Owner

squidfunk commented Oct 12, 2016

Thank you for your contribution, however personally I think that prepending the $ breaks the ability to simply copy and paste the commands and removing the # breaks the syntax highlighting, so sorry, I'm not a fan.

Regarding the newlines: yes, those should be included in the files and were missing in my editor (clumsy me). I have a rewrite of the documentation on my list as a lot of stuff changed :-)

@brendo
Copy link
Contributor Author

brendo commented Oct 12, 2016

No worries! Would you prefer I pair this PR back to just focus on the bower and newlines or simply close it?

@squidfunk
Copy link
Owner

@brendo would be awesome, then I could merge it directly.

@brendo
Copy link
Contributor Author

brendo commented Oct 12, 2016

Done 👍

@squidfunk squidfunk merged commit 1d63713 into squidfunk:rework Oct 12, 2016
@brendo brendo deleted the doc-updates branch October 12, 2016 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants