Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List item inside code annotation not rendering correctly #5633

Closed
4 tasks done
bnigh opened this issue Jun 23, 2023 · 3 comments
Closed
4 tasks done

List item inside code annotation not rendering correctly #5633

bnigh opened this issue Jun 23, 2023 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@bnigh
Copy link

bnigh commented Jun 23, 2023

Context

No response

Bug description

When including multiple annotations for a code block and an annotation contains a nested list, then the annotations do not render correctly.

The one annotation is rendering with the second unordered list item blank, and another annotation's content is replaced by the text of that missing list item.

This seems to be related to #5496, although is impacting code annotations for public version

Related links

Reproduction

example.zip

Steps to reproduce

MkDocs version: 1.4.3
Material version: 9.1.16

    ```bash
    echo "foo" # (1)!
    echo "bar" # (2)!
    ```
    
    1. The beginning of the first annotation, which includes a:
	    
	    - list
	    - of
	    - items
	    
	    Plus another sentence.
	    
    2. Here's the second annotation.

And they render like

Screen Shot 2023-06-22 at 7 41 44 PM

Screen Shot 2023-06-22 at 7 47 11 PM

Browser

No response

Before submitting

@squidfunk
Copy link
Owner

squidfunk commented Jun 23, 2023

Thanks for reporting! Fixed in 3be797e. Indeed, the fix should've been added to the community edition as well. My fault 😅

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open labels Jun 23, 2023
@squidfunk
Copy link
Owner

Released as part of 9.1.17.

@bnigh
Copy link
Author

bnigh commented Jun 24, 2023

Can confirm this resolves the issue I saw. Thank you (especially for such quick turn-around)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants