Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use extra.version if it is available when generating source partial #58

Merged
merged 1 commit into from
Oct 23, 2016

Conversation

brendo
Copy link
Contributor

@brendo brendo commented Oct 23, 2016

A very small change remove the hardcoded version in source.html. It now uses extra.version set in the mkdocs.yml config.

In future, it may be possible to retrieve this information from the Github API along with the stargazers and fork counts.

@brendo brendo changed the title Use extra.version if it is available when generating source partial Use extra.version if it is available when generating source partial Oct 23, 2016
@squidfunk
Copy link
Owner

I was thinking of making this entirely dynamic, because it makes no real sense when we are loading changes from the GitHub API anyway. There are already traces of some prototyping in application.js which I have to refactor.

@brendo
Copy link
Contributor Author

brendo commented Oct 23, 2016

That's true, but for Gitlab and Bitbucket sources it will be difficult to retrieve that data as they don't expose public API's in the same way that Github does.

@squidfunk
Copy link
Owner

Okay, I will merge it and check the GitLab and BitBucket APIs later. Thanks for your contribution!

@squidfunk squidfunk merged commit e61f12d into squidfunk:rework Oct 23, 2016
@brendo brendo deleted the dynamic-source-version branch October 23, 2016 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants