Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: version selector not 'hoverable' on some Android devices #5806

Merged
merged 1 commit into from Aug 21, 2023

Conversation

axieum
Copy link
Contributor

@axieum axieum commented Aug 6, 2023

It appeared that the pointer media query for my Pixel 7 Pro device was reporting as pointer: fine, meaning the hover fix wasn't applying to the Version selector.

I can see this is already being used here:

// Show tooltip for touch devices
@media (hover: none) {

I confirmed working on Desktop, Android, and an iOS mobile device, but it may be best to triple check iOS compatibility please.

Developer Note: When you have Dev Tools connected to the Android device, it changes to pointer: coarse and works as expected, making debugging quite difficult. So you mustn't observe with Dev Tools open while trying to reproduce the error on an Android device.

Fixes #2429

@squidfunk
Copy link
Owner

squidfunk commented Aug 6, 2023

Thanks for the PR! I'm not feeling confident to merge this through right now, because some touch devices will not match hover: none (need to check for more sources), at least as far as I know. IIRC, pointer: coarse is the recommendation and we probably should switch other parts of our code base to it, but I don't have an Android or Windows phone at my disposal, so we definitely need to test this thoroughly before merging with the help of other users.

@axieum
Copy link
Contributor Author

axieum commented Aug 6, 2023

Agreed. I did originally have @media (pointer: coarse), (hover: none) {, shall I bring that back?

@squidfunk
Copy link
Owner

If you're confident that it solves the problem, we can give it a try.

@squidfunk squidfunk changed the base branch from master to merge/piri-piri August 21, 2023 16:06
@squidfunk squidfunk merged commit 92be65e into squidfunk:merge/piri-piri Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version selector not touch-friendly for Android devices
2 participants