Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint to Gulp, break it out as a seperate task #60

Closed
wants to merge 1 commit into from

Conversation

brendo
Copy link
Contributor

@brendo brendo commented Oct 31, 2016

This small PR exposes the existing lint tasks as a dedicated Gulp task so that we can easily check lint during development.

I've also fixed up the failing files so Travis should be happy.

@squidfunk
Copy link
Owner

squidfunk commented Oct 31, 2016

I did exactly the same last night - I put the scripts into bin, because they will get longer and then it will become unreadable very quickly. Also added a lint script which uses eslint and sass-lint directly. This is faster than invoking Gulp, because Gulp first needs to transpile all tasks. IMHO it's better we leave it like that.

Furthermore, the Gulp tasks run in parallel and if one of the linting tasks fails, the other may not run. This is handled in the script bin/lint, which definitely runs both linters and then combines the exit codes.

@brendo
Copy link
Contributor Author

brendo commented Oct 31, 2016

Nice!

@brendo brendo closed this Oct 31, 2016
@brendo brendo deleted the fix-lint branch October 31, 2016 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants