Replaced mutable argument default by None
#6541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Next time, please build the theme and also make sure that your changes are reflected in the |
|
FWIF, I'm referring to 175df61. |
|
Oh, I wasn't aware that changes to the plugins also need a fresh build. 🫣 I'll try to remember it. 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the use of a mutable argument default (here, a
dictliteral), which can introduce bugs that are a bit hard to debug. Here, it doesn't seem to be a problem becauseself.attrsisn't mutated, but it's generally discouraged to use mutable argument defaults. See https://docs.astral.sh/ruff/rules/mutable-argument-default/#mutable-argument-default-b006 for more details.