Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown formatted mermaid nodes do not follow text color of dark theme #6700

Closed
4 tasks done
schneekluth opened this issue Jan 27, 2024 · 4 comments
Closed
4 tasks done
Labels
bug Issue reports a bug 🏆 perfect Issue is of outstanding quality resolved Issue is resolved, yet unreleased if open

Comments

@schneekluth
Copy link

Context

No response

Bug description

When formatting a mermaid node using markdown the text color is not inherited from dark theme. The node is rendered unreadable.

example

Related links

Reproduction

9.5.5-mermaid-vs.zip

Steps to reproduce

  1. Minimal Reproduction Example contains a Markdown formatted mermaid node
  2. Turn on dark theme

Browser

No response

Before submitting

@squidfunk
Copy link
Owner

Thanks for reporting and providing the excellent reproduction! This made fixing the problem straight forward. Fixed in 335dd3a, which sets the text color for Markdown-formatted nodes.

@squidfunk squidfunk added bug Issue reports a bug resolved Issue is resolved, yet unreleased if open 🏆 perfect Issue is of outstanding quality labels Jan 28, 2024
@squidfunk
Copy link
Owner

Released as part of 9.5.6.

@bennert
Copy link

bennert commented Jan 29, 2024

I tested 9.5.6, Most of it looks fine, but I noticed that for "pie", "quadrantChart", "gantt" and "journey" the text color is still not inherited from dark theme

@squidfunk
Copy link
Owner

Well, I was only to able to verify the data that was given to us in the minimal reproduction. If you discover more cases, please provide a complete minimal reproduction so we can solve all of them. Please create a new issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug 🏆 perfect Issue is of outstanding quality resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

3 participants