-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mkdocs 1.0 #834
Comments
Thinking about it - let's do a PR, so we can directly make changes. In this PR we could set MkDocs to version 1.0 and so see directly if it builds. |
Ah, I setup my docs today without realizing that mkdocs v1.0 isn't supported yet. Everything seemed to work except:
|
Yep, I think there's not much we need to do to support MkDocs 1.0, but I don't want to support multiple versions of MkDocs because it introduces breaking changes that would mean we'd need to publish multiple versions of Material which does not really work with PyPI. Once MkDocs 1.0 is out I will make the changes and we will set the minimum required version to 1.0 and drop support for 0.17.x. |
It's out since yesterday 😆 |
Haha oh man, I missed it 😅 I will try to push out a new version this weekend. |
I added basic MkDocs 1.0 support in d7a32d0. Feel free to check out the latest
|
@squidfunk Thanks for your work. I'm writing here to report some of my recent discovery.
I've checked the recent CI log in this repo, it's strange that mkdocs 1.0 can't be installed with pip. Actually I installed successfully with pip yesterday (which caused my CI to fail because of the new version).
check this link: OI-wiki/OI-wiki#61 log of the failed one: https://travis-ci.org/24OI/OI-wiki/builds/412135494 UPD: tested on my own computer and resulted the same error.
Really looking forward to this, it'll be great if the new search will be able to work well with Chinese characters, XD. |
@Ir1d: thanks for reporting! The failing build uses version 0.17.3, therefore it fails because we need to make backward incompatible changes. The search should actually work with Chinese characters, there are some projects using it with the Chinese language. |
@squidfunk Thanks for informing. i forgot i was using 0.17.3. the ci has passed now and i'll test more later today. (I'll update the comment here) As what I've checked today, the refactored search in v1.0 didn't provide much help in supporting Chinese tokenizing. A popular workaround is to modify some files in mkdocs to use |
Travis fails over and over again with the error I stated above. Already tried to clear the caches, still happening. Does somebody with Python experience have an idea why this might be happening? |
@squidfunk not sure about this, but perhaps you can try pip3 ? |
Maybe upgrade pip? I had some weird issues locally installing new packages a while ago because I was on an old pip. They changed a number of things. I can maybe take a look soon. |
|
Well, it's the Travis pip installation. But I'll try upgrading it before installing the dependencies. It would be awesome if somebody with a Python background could try debug this and maybe make some improvements on the build. I'm really not a Python pro and find it really hard to even get a reproducible dev environment up and running (does somebody have some guidelines)? |
Switching Travis to Python 3.6 seems to work fine |
Just released 3.0.0 - Please see the release notes for instructions how to upgrade. Unfortunately, pre-building the index is currently not supported as this needs some more work and I wanted to get 1.0 support out as soon as possible. |
Follow-up from #831 that set the correct dependency version on v2.9.4.
Known problems:
The text was updated successfully, but these errors were encountered: