404 Page is not working properly

[barreeeiroo]

Description

When accessing to a non existing page, the 404 is broken sometimes

Expected behavior

It should render like this:

Actual behavior

It sometimes rendering like this:

Steps to reproduce the bug

1. Go to https://docs2.makeroid.io/foo (working fine)
2. Go to https://docs2.makeroid.io/foo/bar (broken)

Package versions

I'm using GitHub Pages, everything is on a public repo:
https://github.com/Makeroid/Documentation

Project configuration

Can be found here

System information

• OS: GitHub Pages

[martinbira]

Just reproduced this myself.
Worth noting is that as above, https://docs2.makeroid.io/foo, this works, but just adding a trailing slash, https://docs2.makeroid.io/foo/ breaks the 404.

[barreeeiroo]

If you check in gh-pages the 404.html file (as well as Console), it seems like it's using a relative path and not an absolute path, so maybe that can be issue

But how to fix it? 🤔

[squidfunk]

Hmm, works for me: https://squidfunk.github.io/mkdocs-material/this/should/work/

[squidfunk]

What version of MkDocs and Material are you using?

[barreeeiroo]

These ones:

[squidfunk]

Could you try adding a slash at the end of your site_url?

[barreeeiroo]

Still not working 😕

[barreeeiroo]

It is supposed that this page should have an absolute path, such us /assets/etc instead of assets/etc, no?

https://github.com/Makeroid/Documentation/blob/gh-pages/404.html#L47

[squidfunk]

It actually must have an absolute path because it's a single HTML file that is located at the top of the document root. Relative paths would actually break it the exact way you are reporting because the relative path won't correctly resolve for subdirectories.

[barreeeiroo]

Even on localhost is broken, but what can be the cause of this issue?

[barreeeiroo]

BTW, I'm getting several of these on the console, but MKDocs builds the site fine (except 404 page)
ERROR:root:Meta data not found: component
Maybe it can be releated to it (?)

[squidfunk]

I'm sorry, I'm out of ideas. It's perfectly working on the official docs. Maybe someone else experienced the same issue and fixed it?

[facelessuser]

I believe this may be an upstream issue. When dealing with MkDocs issues, it is also helpful to check the MkDocs issues page: mkdocs/mkdocs#1598. Many issues at times are related to the actual MkDocs library and not to specific themes.

[barreeeiroo]

I've found that this website has the same issue: http://elmahio.github.io/blog/notfound
I'll take a look to that MKDocs Issue 👍