Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace SVG's with Font Awesome icons #86

Closed
brendo opened this issue Jan 5, 2017 · 3 comments
Closed

Replace SVG's with Font Awesome icons #86

brendo opened this issue Jan 5, 2017 · 3 comments

Comments

@brendo
Copy link
Contributor

brendo commented Jan 5, 2017

Based on #79, thinking about this a little more, could we use Font Awesome for the icons for the repo_type instead of the SVG's? It has support for our three current types, Gitlab, Bitbucket and Github and I believe this would remove all SVG's from the project, reducing it's dependencies.

Because the icons are fonts, we're able to apply colour to them without needing the -black/-white variants.

Thoughts?

@squidfunk
Copy link
Owner

Theoretically possible, but then FontAwesome would be a mandatory dependency and we already have the Material Icons. I want the theme as lightweight as possible, so in my opinion not the recommended way to go.

@brianjking
Copy link

I agree with @squidfunk on this as using the Material Design icon library makes the most sense with this theme.

@squidfunk
Copy link
Owner

Thanks @brianjking FontAwesome is just an addition for the social icons, because Material doesn't have them. Therefore it should never be included by default, at least in my opinion. If you want to include it, it's very easy to do with extra_javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants