New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement downloading of .NET 4.5 in Setup.exe #12
Comments
As a bonus would it be possible to embed .NET 4.5 in the setup ? :) |
@peters .NET 4.5 doesn't have redist rights afaik. Or does it? |
@paulcbetts yolo 👯 it may be a waste of time though.. in our use case it would be sufficient to just specify our own url to the redist 👍 |
From http://msdn.microsoft.com/en-us/library/5a4x27ek(v=vs.110).aspx:
|
Personally I would rather have it downloadable, but there is potentially some advantages for some people in doing two builds one with it downloadable and one with it built in |
What about .net 4.5.1? |
I'm not suuuuuper excited to include .NET 4.5 in the setup tbh, that makes every Setup.exe huge. What I could do is make it so that if you put the .NET 4.5 installer in the same directory as setup.exe we'll just use it. |
👍 |
I'm willing to implement this, since I won't be able to ship without it. |
@mwcampbell Cool, I'd take that PR :) WTL is already in the project so it should give you basically what you need to implement a "Downloading..." dialog with a progress bar. |
@mwcampbell That'd be GREAT! |
Like it says on the tin, don't just pop a dialog
The text was updated successfully, but these errors were encountered: