Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement downloading of .NET 4.5 in Setup.exe #12

Closed
anaisbetts opened this issue Aug 4, 2014 · 11 comments · Fixed by #114
Closed

Implement downloading of .NET 4.5 in Setup.exe #12

anaisbetts opened this issue Aug 4, 2014 · 11 comments · Fixed by #114

Comments

@anaisbetts
Copy link
Contributor

Like it says on the tin, don't just pop a dialog

@anaisbetts anaisbetts added this to the 0.8 - Feedback release milestone Aug 4, 2014
@peters
Copy link
Contributor

peters commented Sep 4, 2014

As a bonus would it be possible to embed .NET 4.5 in the setup ? :)

@anaisbetts
Copy link
Contributor Author

@peters .NET 4.5 doesn't have redist rights afaik. Or does it?

@peters
Copy link
Contributor

peters commented Sep 4, 2014

@paulcbetts yolo 👯

it may be a waste of time though.. in our use case it would be sufficient to just specify our own url to the redist 👍

@akoeplinger
Copy link

From http://msdn.microsoft.com/en-us/library/5a4x27ek(v=vs.110).aspx:

Both installers are redistributable, so you can include them in the setup program for your app.

@stefanolson
Copy link

Personally I would rather have it downloadable, but there is potentially some advantages for some people in doing two builds one with it downloadable and one with it built in

@stefanolson
Copy link

What about .net 4.5.1?

@anaisbetts
Copy link
Contributor Author

I'm not suuuuuper excited to include .NET 4.5 in the setup tbh, that makes every Setup.exe huge. What I could do is make it so that if you put the .NET 4.5 installer in the same directory as setup.exe we'll just use it.

@peters
Copy link
Contributor

peters commented Sep 4, 2014

👍

@mwcampbell
Copy link

I'm willing to implement this, since I won't be able to ship without it.

@anaisbetts
Copy link
Contributor Author

@mwcampbell Cool, I'd take that PR :) WTL is already in the project so it should give you basically what you need to implement a "Downloading..." dialog with a progress bar.

@stefanolson
Copy link

@mwcampbell That'd be GREAT!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants