Draw forecast of now+[3,6,9,12] hours #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the absolute hours 3,6,9,12 were drawn. A simple helper function handles the 24 hour wrap around. Note that if minutes are 30+, one additional hour is added for rounding.
marcelstoer
reviewed
Apr 13, 2018
| @@ -292,11 +292,24 @@ void drawCurrentWeather() { | |||
|
|
|||
| } | |||
|
|
|||
| unsigned int hourAddWrap(unsigned int hour, unsigned int add) { | |||
| hour += add; | |||
| if(hour > 23) hour -= 24; | |||
There was a problem hiding this comment.
Hmm, did you test with 12hour style as well?
-> https://github.com/ThingPulse/espaper-weatherstation/blob/master/settings.h#L98
There was a problem hiding this comment.
Never mind, just tested for a while and it looks good.
|
Thanks 👍 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the absolute hours 3,6,9,12 were drawn.
A simple helper function handles the 24 hour wrap around. Note that if minutes are 30+, one additional hour is added for rounding.