Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a PSR-5 and PSR-12 #1309

Closed
gmponos opened this issue Jan 25, 2017 · 2 comments
Closed

Create a PSR-5 and PSR-12 #1309

gmponos opened this issue Jan 25, 2017 · 2 comments

Comments

@gmponos
Copy link
Contributor

gmponos commented Jan 25, 2017

I was wondering if there could be a way for developers to start working and creating sniffs on these PSRs (PSR-5 - PSR-12)

For instance I have a sniff that checks for deprecated PHPDoc tags according to PSR-5. If I make a PR creating a new standard named PSR-5 having only this sniff will it be accepted? This way more developers can influenced to create more PRs about these PSRs.

I know that these PSRs are currently in Draft state and you might reasonably say that things might change but for instance for the sniff that I mention I don't think that these tags that are deprecated in PSR-5 will become un-deprecated.

@gsherwood
Copy link
Member

Yes, I would accept that PR. But given they are in draft, I'd rather include them in the 3.0 branch because I don't think the PSRs will be approved before 2.x has finished its run. I don't want to include an incomplete (or worse, incorrect) standard in there.

@gsherwood
Copy link
Member

Closing this as question was answered. To my knowledge, nobody is currently working on sniffs for either PSR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants