You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just ported over some changes/fixes from Squiz.Commenting.FunctionComment PHPCS 3.x branch to our custom sniff Joomla.Commenting.FunctionComment (PR with the change is joomla/coding-standards#229 )
For some reason the PEAR.ControlStructures.MultiLineCondition.Alignment is struggling here with the Multi-line IF statements and tab alignment
the same lines give the following errors depending on which indent fix is implemented
Note: I've been doing manual corrections here; I have not been using phpcbf to fix these errors, as such I keep going in circles (infinite loop of opposing indent errors)
The text was updated successfully, but these errors were encountered:
Sorry, but I've only just gotten to this in my list.
I'm really short on time, so is there any way you could just give me a small snippet of code to reproduce the error + a command I can run to do so using the included sniffs? Or if you need help debugging a custom sniff, just let me know where to grab it from.
In trying to get a small file showing the issue I can no longer replicate the issue.
Even the main repo file were the issue was occurring I was able to directly fix the indent issue with no problem.
Not sure what was going on a month ago, but it works correctly now.
I just ported over some changes/fixes from
Squiz.Commenting.FunctionComment
PHPCS 3.x branch to our custom sniffJoomla.Commenting.FunctionComment
(PR with the change is joomla/coding-standards#229 )For some reason the
PEAR.ControlStructures.MultiLineCondition.Alignment
is struggling here with the Multi-line IF statements and tab alignmentthe same lines give the following errors depending on which indent fix is implemented
Multi-line IF statement not indented correctly; expected 32 spaces but found 28.
https://travis-ci.org/photodude/coding-standards/jobs/339755077
or after fixing by adding one tab and it errors as follows
Multi-line IF statement not indented correctly; expected 28 spaces but found 32.
https://travis-ci.org/photodude/coding-standards/jobs/339755650
Example code erroring
https://github.com/photodude/coding-standards/blob/patch-2/Joomla/Sniffs/Commenting/FunctionCommentSniff.php#L156-L160
Note: I've been doing manual corrections here; I have not been using
phpcbf
to fix these errors, as such I keep going in circles (infinite loop of opposing indent errors)The text was updated successfully, but these errors were encountered: