Squiz.Functions.FunctionDeclarationSpacing error for multi-line declarations with required spaces greater than zero #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the `Squiz.Functions.FunctionDeclarationSpacing` sniff when the `requiredSpacesAfterOpen` option was set to anything other than 0. When the first argument in a multiline function declaration had a type-hint, this error would be given: > Expected 1 spaces between opening bracket and type hint "array"; 0 found I don’t think this check was ever intended to affect multiline functions. The logic was such that it never does when `requiredSpacesAfterOpen` is 0, and because this is the default, the bug was never noticed.
gsherwood
changed the title
gsherwood
added a commit
that referenced
this pull request
Aug 20, 2015
|
Thanks for the test and the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the
Squiz.Functions.FunctionDeclarationSpacingsniff when the
requiredSpacesAfterOpenoption was set to anythingother than 0.
When the first argument in a multiline function declaration had a
type-hint, this error would be given:
I don’t think this check was ever intended to affect multiline
functions. The logic was such that it never does when
requiredSpacesAfterOpenis 0, and because this is the default, thebug was never noticed.