New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructured and modularized code #5
Conversation
Hey, sorry for the delay. Looks like a good start. Can you:
|
Done! |
@AdityaKane2001, will do. PR lgtm, but README.ipynb seems to be corrupted. Do you also get this issue, and can you revert the notebook so it's non-corrupted? |
Restored the notebook. Thanks for the invitation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I ran the tests locally they pass. Thanks for adding the license + formatting. I was never 100% sure about the modularisation, but happy to go with it and see how it works out.
I see. Thanks for merging! Let me know what's the upcoming agenda. Edit: I'd just need a few days to read up the code. I'm not yet completely familiar with the code, so I'll just go through it and then I'll start any new tasks. Sounds good? |
@AdityaKane2001, np!
No problem, let me know if you have any questions. I think the documentation could be improved, and I do plan to write a more tutorial style guide to the implementation at some point. The stuff on this todo list still looks good, and I'm happy to hear other ideas too. |
@sradc
As discussed I have modularized the code in a way I think is best. Please take a look at the structure and let me know if you think there need to be any changes. All tests are passing.