Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not stop a query #384

Closed
dpordomingo opened this issue Mar 28, 2019 · 6 comments
Closed

Can not stop a query #384

dpordomingo opened this issue Mar 28, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@dpordomingo
Copy link
Contributor

Trying to stop a query either run from mysql client, srcd sql client, or srcd sql command does not work as expected because it keeps running on background as it can be seen if querying the PROCESSLIST.

It works if quering and cancelling from gitbase-web.

using:

  • docker version: 1.39
  • srcd cli version: v0.11.0
  • srcd daemon version: v0.11.0
  • srcd/gitbase: v0.19.0
  • srcd/gitbase-web: v0.6.2
@dpordomingo dpordomingo added the bug Something isn't working label Mar 28, 2019
@carlosms
Copy link
Contributor

How are you cancelling the query exactly? kill, kill connection, kill query?

@dpordomingo
Copy link
Contributor Author

I think that Ctrl+C should be also captured by srcd sql and kill the query being processed.

@smacker
Copy link
Contributor

smacker commented Mar 28, 2019

that is not how mysql clients work. Exit only breaks the connection and we do it right now. Imo it's better to keep engine behavior consistent with the user's prior knowledge.

@carlosms
Copy link
Contributor

carlosms commented Apr 4, 2019

can we close this one @dpordomingo?

@dpordomingo
Copy link
Contributor Author

I still could not kill some queries, even with kill command from another mysql client from another shell tab... but could not describe the problem good enough to be fully reproducible...
So... we could close... and I'll reopen once I have more data to describe the problem.

@carlosms
Copy link
Contributor

carlosms commented Apr 4, 2019

Closing, since Engine sql client works as expected. If you have any problem using kill it is most probably not related to Engine.
Also, take a look at this one, in case you hit a related problem: src-d/go-mysql-server#635

@carlosms carlosms closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants