Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest-drivers bblfsh image #67

Closed
carlosms opened this issue Oct 9, 2018 · 7 comments
Closed

Use latest-drivers bblfsh image #67

carlosms opened this issue Oct 9, 2018 · 7 comments
Labels
empathy-sessions Issue filed as as part of empathy sessions

Comments

@carlosms
Copy link
Contributor

carlosms commented Oct 9, 2018

With the current bblfsh v2.90 a bblfshctl driver install fails for already installed drivers (context here).

This means we can get errors like this:

$ srcd parse uast ~/repos/gitbase-web/cmd/gitbase-web/main.go 
FATA[0000] could not stream: rpc error: code = AlreadyExists desc = driver already installed: go (image reference: docker://bblfsh/go-driver:latest): %s 

We should add the new --force flag to bblfshctl (which actually means ignore, not force), or use the new latest-drivers images.

@smacker
Copy link
Contributor

smacker commented Oct 23, 2018

The error mentioned in the issue is fixed here: src-d/sourced-ce#84
But we still can consider using latest-drivers image.

@smacker
Copy link
Contributor

smacker commented Oct 25, 2018

I have noticed one problem with latest-drivers. This image follows bblfshd release cycle. So it doesn't get updates when bugs are fixed in drivers or even new features are added.

As an example right now the latest drivers image is v2.9.1-drivers https://hub.docker.com/r/bblfsh/bblfshd/tags/ released 15 days ago.
But the java-driver is released 20 hours ago https://hub.docker.com/r/bblfsh/java-driver/tags/
It is 2 releases newer with changes:

  • Fix roles for primitive types
  • Support error codes

@smacker
Copy link
Contributor

smacker commented Oct 26, 2018

Right now we have very good example of why it's problem:
We have bblfsh-web v0.8.0 but it can't work with current latest drivers image. Only with a normal one because it requires newer drivers.

@campoy
Copy link
Contributor

campoy commented Nov 17, 2018

We should still fix this, though.
Currently "sql web sql" takes minutes due to the lag of installing every single driver.
It should start in seconds.

@smacker
Copy link
Contributor

smacker commented Nov 19, 2018

In my opinion, we need to discuss it with LA team and agree on some kind of schedule for -drivers releases or something like that.

Current release was made 24 days ago, since then in java-driver, for example, was created 3 new releases:

  • Enable language namespace in Semantic UAST
  • Annotate default function modifier.
  • Normalize and annotate Javadoc nodes properly.

We need to incorporate those improvements into engine somehow at some point.

cc @creachadair

@creachadair
Copy link
Contributor

The above sounds sensible to me. At the very least, it seems like we should have some coordination around which semantic version ranges are compatible with each other. Tightly-coupled releases are hard to maintain, but there should be some middle ground between that and confusing/surprising behaviour for the user.

@smacker
Copy link
Contributor

smacker commented Nov 20, 2018

here is the change to -drivers image: src-d/sourced-ce#135

but it still downloads cpp driver separately. Because cpp driver is recommended already but isn't included in latest drivers image. (one more example why we need some kind of coordination with LA team)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
empathy-sessions Issue filed as as part of empathy sessions
Projects
None yet
Development

No branches or pull requests

5 participants