Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enry --json does not end the line #60

Closed
vmarkovtsev opened this issue Jul 5, 2017 · 4 comments
Closed

enry --json does not end the line #60

vmarkovtsev opened this issue Jul 5, 2017 · 4 comments
Assignees
@dpaz

Comments

@vmarkovtsev
Copy link
Collaborator

Since linguist --json does not pretty-print JSON, I suggest to not pretty print in enry --json too.
@dpaz
Copy link
Contributor

dpaz commented Jul 5, 2017

The current version of enry not pretty print with the option -json

@vmarkovtsev
Copy link
Collaborator Author

vmarkovtsev commented Jul 5, 2017 •
edited

Indeed. But linguist outputs the new line char in the end. We don't.

@vmarkovtsev vmarkovtsev changed the title enry --json should output a single line enry --json does not end the line Jul 5, 2017
@dpaz dpaz self-assigned this Jul 5, 2017
@dpaz dpaz mentioned this issue Jul 5, 2017
Merged
@bzz
Copy link
Contributor

bzz commented Jul 7, 2017

It should be safe to close this now, as soon as #63 is merged

@abeaumont
Copy link
Contributor

@bzz you're right. I don't have permissions to close it though. So either @vmarkovtsev or @smola will have to do it.

@abeaumont abeaumont mentioned this issue Jul 11, 2017
Closed
@dpaz dpaz closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpaz dpaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@abeaumont @vmarkovtsev @bzz @dpaz