Skip to content

Commit

Permalink
Merge pull request #83 from mcarmonaa/fix/siva-repositories-release-l…
Browse files Browse the repository at this point in the history
…ocation-lock

siva: release location lock rolling back if repository saveVersion fails
  • Loading branch information
jfontan committed Aug 7, 2019
2 parents 14abcd2 + bbd9b97 commit 63019a4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion siva/repository.go
Expand Up @@ -13,7 +13,7 @@ import (
) )


// ErrRepoAlreadyClosed is returned when a repository opened in RW mode was already closed. // ErrRepoAlreadyClosed is returned when a repository opened in RW mode was already closed.
var ErrRepoAlreadyClosed = errors.NewKind("repository % already closed") var ErrRepoAlreadyClosed = errors.NewKind("repository %s already closed")


// Repository is an implementation for siva files of borges.Repository // Repository is an implementation for siva files of borges.Repository
// interface. // interface.
Expand Down Expand Up @@ -108,6 +108,8 @@ func (r *Repository) Commit() error {


err := r.saveVersion() err := r.saveVersion()
if err != nil { if err != nil {
// TODO: log the rollback error
_ = r.location.Rollback(r.mode)
return err return err
} }


Expand Down

0 comments on commit 63019a4

Please sign in to comment.