Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add API to post a PR comment #581

Open
vmarkovtsev opened this issue Mar 5, 2019 · 4 comments
Open

[feature] Add API to post a PR comment #581

vmarkovtsev opened this issue Mar 5, 2019 · 4 comments

Comments

@vmarkovtsev
Copy link
Collaborator

As we have already seen many times with running style-analyzer in practice, it is often confusing to people why no comments are generated. There can be several reasons, and some of them are warnings, e.g.: too small repo or no supported languages or too much time taken for training.

I suggest to add an API to post a regular message into the PR thread. We would use it to report those notices/warnings/errors. My favorite use case would be posting "I am still alive" messages every hour.

@vmarkovtsev
Copy link
Collaborator Author

cc @marnovo

@vmarkovtsev
Copy link
Collaborator Author

@smacker
Copy link
Contributor

smacker commented Mar 5, 2019

If you return comment without file as it's described in proto file, such comment will be posted as a normal regular comment. Does it solve your problem?

@dpordomingo
Copy link
Contributor

to post regular messages, the way that @smacker suggested should be the ok.
But for other purposes Lookout could increase its api;
example: isMergeable, as part of the Analyzer EventResponse, could be used for Lookout to mark the PR as mergeable or not (as Travis does).
... and many other ways to communicate common things from the Analyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants